Add --kubeconfig option to tridentctl #735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netapp-ci-sync
bot
force-pushed
the
master
branch
from
5ccfdf7
to
94d0bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This PR will add an optional --kubeconfig argument to specify a kubeconfig file to use, similar to kubectl and oc.
Project tracking
see #734)
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
No, this only adds one optional argument that is no-op when not specified
Does this code need functional testing?
The changes do not change the main logic of the tridentctl code.
I have tested it using different commands and kubeconfig files and it is working.
Is a code review walkthrough needed? why or why not?
Probably not needed as the changes are relatively simple and only touch a few files
Should additional test coverage be executed in addition to pre-merge?
May require adding test that pass a specific kubeconfig file
Does this code need a note in the changelog?
Yes - same as title of this PR
Does this code require documentation changes?
Yes - self descript line to be added is sufficient as users are already familiar with the argument from using kubectl and oc
Additional Information