-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Azure): Incorporate azure resources #830
base: master
Are you sure you want to change the base?
Conversation
This PR is checkout from #829 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add more details in the PR description? .e.g.
currently we need to create netapp account, netapp volumes, configure vnet, what will this PR do?
https://learn.microsoft.com/en-us/azure/aks/azure-netapp-files-nfs
also there is smb volume, how to deal with that?
…orate-azure-resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's first merge #829 first since this PR depends on that PR, and also provide a feature flag to decide whether doing following things automatically, by default it's true, and user could disable it if there is sth. wrong:
Create a netapp account
Create capacity pool
Create subnet and delegate to Azure NetApp Files
I've added manual test steps in the description. |
…orate-azure-resources
I've tested with Azure official doc successfully, so there should be no regression. |
…orate-azure-resources
c565a4d
to
3ca8e25
Compare
5ccfdf7
to
94d0bf7
Compare
Change description
feat: Incoporate azure resources
Per Azure official document, users have to complete following steps before they deploy trident and create tbc (tridentbackendconfig):
This PR tries to incorporate these steps into the process of initialing Azure driver in trident. Users do not need to create these Azure resources anymore. All they need is to deploy trident and then create a tbc.
After a tbc deployed, trident-orchestrator starts to initialize Azure driver, it will discover netapp account, capacity pool and subnet and they make up the virtual storage pools. What this PR implement is that when these Azure resources are not explicitly specified in tbc, and no Azure resource can be discovered, trident-orchestrator will create them.
Project tracking
Do any added TODOs have an issue in the backlog?
Did you add unit tests? Why not?
Does this code need functional testing?
Is a code review walkthrough needed? why or why not?
Should additional test coverage be executed in addition to pre-merge?
Does this code need a note in the changelog?
Yes. feat(Azure): Incorporate azure resources.
Does this code require documentation changes?
Yes.
Additional Information
Manual test steps
1. create an aks cluster
2. add necessary permission to aks managed identity
3. build and push image
4. deploy trident
5. create TridentBackendConfig and wait until it creates backend successfully.
6. Create SC, PVC, Pod