Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building with quota and libtirpc on Fedora 40 #1040

Merged
merged 1 commit into from
May 31, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented May 29, 2024

configuring with quota and libtirpc -- turned out that we need a capability check to make this work on Fedora

tracker isn't a dependency of tracker-devel in Fedora, so let's install it explicitly

@rdmark rdmark requested a review from a user May 29, 2024 13:20
@rdmark rdmark changed the title GitHub CI: Explicitly install tracker on Fedora GitHub CI: quota and tracker on Fedora May 29, 2024
@rdmark rdmark marked this pull request as draft May 29, 2024 14:04
@rdmark rdmark force-pushed the rdmark-fedora-tracker branch from e7dc13b to 0c5f2fe Compare May 29, 2024 14:25
@rdmark
Copy link
Member Author

rdmark commented May 29, 2024

Funnily, Fedora's libtirpc is kinda different from libtirpc in other Linux distros. If I hack the enum data type name, the code otherwise builds fine on Fedora. Some clever compatibility abstraction is required...

from rpcsvc/rquota.h

Fedora does

enum qr_status {
	Q_OK = 1,
	Q_NOQUOTA = 2,
	Q_EPERM = 3,
};

Debian (and Solaris etc.) does

enum gqr_status {
	Q_OK = 1,
	Q_NOQUOTA = 2,
	Q_EPERM = 3,
};

With quota compiling on Fedora now, enable this in GitLab actions

tracker isn't a dependency of tracker-devel in Fedora, so let's install it explicitly
@rdmark rdmark force-pushed the rdmark-fedora-tracker branch from 6ed3831 to c76dfa5 Compare May 31, 2024 00:13
@rdmark rdmark marked this pull request as ready for review May 31, 2024 00:14
@rdmark
Copy link
Member Author

rdmark commented May 31, 2024

@dgsga This is a lot of added build system complexity for a single enum having a slightly different name on Red Hat...

But a good learning experience for me. :)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rdmark rdmark merged commit 11efb3a into main May 31, 2024
15 checks passed
@rdmark rdmark deleted the rdmark-fedora-tracker branch May 31, 2024 00:23
@rdmark rdmark changed the title GitHub CI: quota and tracker on Fedora Enable building with quota and libtirpc on Fedora 40 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant