meson: Don't attempt to detect shadow password header on *BSD and macOS #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
1777-meson-shadow-passwords-check-is-invalid-on-netbsd
branch
2 times, most recently
from
2db99d3 to
a3a53ce
Compare
rdmark
force-pushed
the
1777-meson-shadow-passwords-check-is-invalid-on-netbsd
branch
from
a3a53ce to
fa917c4
Compare
rdmark
force-pushed
the
1777-meson-shadow-passwords-check-is-invalid-on-netbsd
branch
from
fa917c4 to
bb9f253
Compare
rdmark
changed the title
|
rdmark
changed the title
rdmark
deleted the
1777-meson-shadow-passwords-check-is-invalid-on-netbsd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadow passwords concept is only a thing on Linux and Solaris. *BSDs and macOS have their own native mechanisms for securing passwords. So we shouldn't attempt to detect shadow.h and throw a warning when not found on those OSes.
We also now print a fallback
passwdin the summary when shadow support not detected. (Not all OSes call this passwd, but I'm using it a shorthand for native password management here.)