Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: Retry logic for final cleanup step in test358 #1797

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Dec 1, 2024

The test cleanup routine in test358 is unreliable on Debian s390x. The dir is sometimes locked by the system when we try to delete it at the end.

This PR adds assertions to the first two file cleanup steps, and retry logic to the final dir cleanup step.

@rdmark rdmark linked an issue Dec 1, 2024 that may be closed by this pull request
@rdmark rdmark force-pushed the 1795-testsuite-test358-is-unreliable-on-debian-s390x branch 2 times, most recently from bee3978 to 35ff1e8 Compare December 1, 2024 16:39
@rdmark rdmark force-pushed the 1795-testsuite-test358-is-unreliable-on-debian-s390x branch from 35ff1e8 to 8aa5e1c Compare December 1, 2024 16:40
@rdmark rdmark changed the title testsuite: Fail early in test358 if test files can't be deleted testsuite: Retry logic for final cleanup step in test358 Dec 1, 2024
Copy link

sonarqubecloud bot commented Dec 1, 2024

@rdmark rdmark marked this pull request as ready for review December 1, 2024 16:42
@rdmark rdmark merged commit 063070e into main Dec 7, 2024
29 checks passed
@rdmark rdmark deleted the 1795-testsuite-test358-is-unreliable-on-debian-s390x branch December 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testsuite: test358 is unreliable on Debian s390x
1 participant