Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy cnid backends #528

Merged
3 commits merged into from
Oct 15, 2023
Merged

Deprecate legacy cnid backends #528

3 commits merged into from
Oct 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2023

This commit removes legacy CNID backends that complicate the user experience without providing significant functional gain

@ghost ghost requested a review from rdmark October 14, 2023 16:32
@ghost ghost linked an issue Oct 14, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ghost ghost self-assigned this Oct 15, 2023
Comment on lines -2221 to -2226
<para>"Concurrent database", backend is based on Oracle Berkeley DB.
With this backend several <command>afpd</command> daemons access the
CNID database directly. Berkeley DB locking is used to synchronize
access, if more than one <command>afpd</command> process is active
for a volume. The drawback is, that the crash of a single
<command>afpd</command> process might corrupt the database.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, when we remove this paragraph the following paragraph for dbd reads kind of awkwardly. We may want to borrow the first sentence?

@ghost ghost merged commit 1cb6294 into main Oct 15, 2023
5 checks passed
@ghost ghost deleted the 508-deprecate-legacy-cnid-backends branch October 24, 2023 10:54
ghost pushed a commit that referenced this pull request May 19, 2024
ghost pushed a commit that referenced this pull request May 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate legacy CNID backends
1 participant