#648: switch to the regular toString for logging to prevent excessive memory usage #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
ghenzler
reviewed
Oct 18, 2022
| @@ -83,7 +83,7 @@ public void persistHistory(PersistableInstallationLogger installLog) { | |||
|
|
|||
| String mergedAndProcessedConfig = installLog.getMergedAndProcessedConfig(); | |||
| if (StringUtils.isNotBlank(mergedAndProcessedConfig)) { | |||
| JcrUtils.putFile(historyNode, "mergedConfig.yaml", "text/yaml", | |||
| JcrUtils.putFile(historyNode, "mergedConfig.txt", "text/plain", | |||
There was a problem hiding this comment.
so this is a shame to have only a "toString" representation saved - isn't it possible to somehow generate the yaml without too much memory impact? (IIRC today snippets of this file can be used to test things and do some "round-tripping")
There was a problem hiding this comment.
suggestions welcome, SnakeYAML itself has huge overhead!
There was a problem hiding this comment.
I suppose we could fairly easily write a toString method, that creates valid yaml (instead of just using ToStringBuilder) - but we can also do that separately, not the most important to have immediately
ghenzler
approved these changes
Oct 19, 2022
This was referenced Oct 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace serialization of config from Yaml to regular toString.
Comparison of memory usage:
Before (OutOfMemory ons serialization)
After (no OutOfMemory)
Example of serialized config in the history