Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

335 block 8 chapter cards #370

Merged
merged 7 commits into from
Aug 8, 2023
Merged

335 block 8 chapter cards #370

merged 7 commits into from
Aug 8, 2023

Conversation

sonaldhekale
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@sonaldhekale sonaldhekale linked an issue Aug 1, 2023 that may be closed by this pull request
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/drafts/sdhekale/chapter-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sonaldhekale
Copy link
Collaborator Author

@mihai-buricea-net or @tomasznetcentric could you please review this?

blocks/chapter-cards/chapter-cards.css Outdated Show resolved Hide resolved
blocks/chapter-cards/chapter-cards.css Outdated Show resolved Hide resolved
blocks/chapter-cards/chapter-cards.css Outdated Show resolved Hide resolved
- add function to franklin lib to create elements
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 4, 2023

Page Scores Audits Google
/drafts/sdhekale/chapter-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

- improves creating elements
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 4, 2023

Page Scores Audits Google
/drafts/sdhekale/chapter-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 4, 2023

Page Scores Audits Google
/drafts/sdhekale/chapter-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

Tested and mostly looks fine.
Two comments however,

  1. The specs mention Dark Teal to be #26EFE9, but it's currently ##06c7cc, is this expected? @Gonzalo-CG
  2. Can we add a Lock function to one of the cards to test that as well as Block 8 Chapter cards #335 mentions a locked card function. @sonaldhekale
    Thanks!
Screenshot 2023-08-04 at 11 34 03 Screenshot 2023-08-04 at 11 34 31

@tomasznetcentric
Copy link
Collaborator

Hey @alexnerdrumhansen :) what do you mean by lock function in your last comment?

@Gonzalo-CG
Copy link
Collaborator

@alexnerdrumhansen @sonaldhekale

  1. The color should be #26EFE9 as per specs.
  2. The lock functionality was dropped after alignment w/ marketing as they don't see the need for it. The locking function was edited out of the specs.

@alexnerdrumhansen
Copy link
Collaborator

Thanks @Gonzalo-CG .
We should update the Main ticket too maybe just to document it there too that no lock mode is needed any more.
Only colour change needed for Dark Teal and we'll be good.
Thanks!

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 4, 2023

Page Scores Audits Google
/drafts/sdhekale/chapter-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

Screenshot 2023-08-04 at 12 36 44 Looks fine, only we have different names for the colours in the Specs which causes some confusion when verifying. https://projects.netcentric.biz/wiki/display/NCWEB/Block+8+Chapter+cards

@sonaldhekale sonaldhekale merged commit 3735fe3 into main Aug 8, 2023
2 checks passed
@sonaldhekale sonaldhekale deleted the 335-block-8-chapter-cards branch August 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block 8 Chapter cards
4 participants