Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#328 - fix text overlaping #372

Merged
merged 1 commit into from
Aug 1, 2023
Merged

#328 - fix text overlaping #372

merged 1 commit into from
Aug 1, 2023

Conversation

mihai-buricea-net
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/drafts/mburicea/careers/expading-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

Copy link
Collaborator

@tomasznetcentric tomasznetcentric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now is fine, but lets think also on nc-web about a general style reset.

@mihai-buricea-net mihai-buricea-net merged commit ce31b61 into main Aug 1, 2023
2 checks passed
@mihai-buricea-net mihai-buricea-net deleted the 328-expanding-cards branch August 1, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants