Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources block #126 #212

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Resources block #126 #212

merged 8 commits into from
Feb 26, 2024

Conversation

SantiagoHomps-NC
Copy link
Contributor

@SantiagoHomps-NC SantiagoHomps-NC commented Feb 5, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 5, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 5, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/shomps/redesign/resources PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 5, 2024 12:12 Inactive
@SantiagoHomps-NC SantiagoHomps-NC changed the title block done Resources Block Feb 5, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 6, 2024 16:13 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 7, 2024 09:24 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 7, 2024 11:58 Inactive
@SantiagoHomps-NC SantiagoHomps-NC marked this pull request as ready for review February 7, 2024 11:59
@cogniSyb
Copy link
Collaborator

cogniSyb commented Feb 8, 2024

We should give this block a different name. Something that describes what it does

cogniSyb
cogniSyb requested changes Feb 8, 2024
View reviewed changes
blocks/v2-resources/v2-resources.css Outdated Show resolved Hide resolved
blocks/v2-resources/v2-resources.js Outdated Show resolved Hide resolved
blocks/v2-resources/v2-resources.css Outdated Show resolved Hide resolved
blocks/v2-resources/v2-resources.css Outdated Show resolved Hide resolved
@cogniSyb cogniSyb added the FR Functional requirement label Feb 8, 2024
@cogniSyb cogniSyb changed the title Resources Block Resources block #126 Feb 8, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 8, 2024 11:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 126-fr-resources-block February 8, 2024 11:25 Inactive
@cogniSyb cogniSyb merged commit 2218108 into develop Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cogniSyb cogniSyb cogniSyb approved these changes

@jonatan-lledo-netcentric jonatan-lledo-netcentric jonatan-lledo-netcentric approved these changes

Assignees

@cogniSyb cogniSyb

Labels
FR Functional requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SantiagoHomps-NC @cogniSyb @jonatan-lledo-netcentric @santi-homps