Rollback the change to use lambdas in Config Proxies. #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of lambdas to call default methods in Config proxy interfaces surfaced memory leaks in applications that leak configuration proxies. Because the lambdas live in the JVMs metaspace, which is often configured to a much smaller max size than the heap, the leaking proxies have a much higher chance of causing OOM errors. We are therefore rolling back this change temporarily, while we investigate a way to re-implement it in a way that reduces the issues.
rgallardo-netflix
added a commit
to rgallardo-netflix/archaius
that referenced
this pull request
Oct 11, 2023
…xies This is a re-factor of the code reverted in PR Netflix#685, originally by @kilink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of lambdas to call default methods in Config proxy interfaces surfaced memory leaks in applications that leak configuration proxies.
Because the lambdas live in the JVMs metaspace, which is often configured to a much smaller max size than the heap, the leaking proxies have a much higher chance of causing OOM errors.
We are therefore rolling back this change temporarily, while we investigate a way to re-implement it in a way that reduces the issues.