Pypl2lib fixes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 15, 2024 12:17
…nnel_data_by_name, pl2_get_analog_channel_data_by_source.
…o and pl2_get_start_stop_channel_data.
nikhilchandra
force-pushed
the
pypl2lib_fixes
branch
from
bc3137c
to
543d35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the following changes to the DLL wrapper encoded in pypl2lib.py:
The 3 functions for retrieving full analog data channels (pl2_get_analog_channel_data/by_name/by_source) each return 3 variables -- fragment_timestamps, fragment_counts, and values. Previously, fragment_timestamps and fragment_counts were arrays of length PL2AnalogChannelInfo.m_MaximumNumberOfFragments. I have amended the code to truncate these arrays to length num_fragments_returned, which is one of the variables returned by the underlying DLL function but not by the wrapper function.
The function pl2_get_analog_channel_data_subset was not previously implemented. I have implemented it with support for Zugbruecke. I would appreciate some feedback here as I am not very experienced with Zugbruecke.
The implementation for pl2_get_start_stop_channel_info and pl2_get_start_stop_channel_data was wrong. I have corrected it.