Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello world! #1

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Hello world! #1

merged 2 commits into from
Feb 18, 2024

Conversation

JayRovacsek
Copy link
Member

First draft of the repository, including:

  • charter documents
  • contributing guide
  • tooling configuration (optional - but consistently applied in CICD)

@JayRovacsek JayRovacsek self-assigned this Feb 10, 2024
@JayRovacsek JayRovacsek requested a review from afsnib February 10, 2024 04:53
Copy link

@nephalemsec nephalemsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, love the pre commit hooks!

Copy link

@colecornford colecornford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. I'm not really sure about the nix components but I read the charter and think its good and contribution is as well.

@JayRovacsek
Copy link
Member Author

It all looks good to me. I'm not really sure about the nix components but I read the charter and think its good and contribution is as well.

Thanks! I might make a change to the contributing document that puts the most common tooling and short path first: a single line docker command - but the tooling is as described, optional - simply enforcing the style, linting, typo checks I believe will enable us to keep the repo pretty clean with very little effort

@JayRovacsek JayRovacsek removed the request for review from afsnib February 18, 2024 05:30
@JayRovacsek JayRovacsek merged commit 3531932 into main Feb 18, 2024
1 check passed
@JayRovacsek JayRovacsek deleted the init branch February 18, 2024 05:32
Copy link

@DeClemo DeClemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants