Skip to content

Commit

Permalink
Rethrow SQLException caught in closeConnection.
Browse files Browse the repository at this point in the history
This could be bad if an SQLException is thrown when the deconstructor
calls closeConnection, as terminate will likely be called.
  • Loading branch information
johannish committed Aug 19, 2013
1 parent a150b22 commit d40d734
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/connection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ void Connection::closeConnection() {
m_connection = NULL;
} catch (oracle::occi::SQLException &ex) {
m_connection = NULL;
throw; // rethrow to allow handler to throw in V8 scope
}
}
}
Expand Down

0 comments on commit d40d734

Please sign in to comment.