Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42: Zoltan: Assess MPI_COMM_WORLD usage and implement a getter #48

Conversation

tlamonthezie
Copy link

@tlamonthezie tlamonthezie commented Jul 17, 2023

Fixes #42

This is still a work in progress.

This PR includes:

  • New function named MPI_Comm_Default() to return currently MPI_COMM_WORLD
  • Call of MPI_Comm_Default() instead of MPI_COMM_WORLD in src/zoltan/src/driver, src/zoltan/src/fdriver, src/zoltan/src/util/memory_usage, src/zoltan/src/util/network_topology, src/zoltan/src/Utilities/Timer, src/zoltan/src/Utilities/Communication, src/zoltan/src/Utilities/Memory, src/zoltan/src/ch, src/zoltan/src/hier, src/zoltan/src/lb, src/zoltan/src/order, src/zoltan/src/phg, src/zoltan/src/tpls, src/zoltan/src/zz and developer README.

@tlamonthezie tlamonthezie self-assigned this Jul 17, 2023
@tlamonthezie tlamonthezie marked this pull request as draft July 17, 2023 12:51
@tlamonthezie tlamonthezie changed the base branch from NGA-FY23-develop to NGA-pr-candidates July 18, 2023 15:31
@tlamonthezie tlamonthezie changed the base branch from NGA-pr-candidates to NGA-FY23-develop July 18, 2023 15:43
@tlamonthezie tlamonthezie linked an issue Aug 4, 2023 that may be closed by this pull request
@thearusable thearusable force-pushed the 42-zoltan-assess-mpi_comm_world-usage-and-implement-a-getter branch from 35aac90 to 50a1677 Compare August 8, 2023 14:05
@thearusable thearusable self-assigned this Aug 8, 2023
@thearusable thearusable force-pushed the 42-zoltan-assess-mpi_comm_world-usage-and-implement-a-getter branch from 69ad444 to 9dfddc4 Compare August 9, 2023 13:08
@thearusable thearusable marked this pull request as ready for review August 9, 2023 14:20
@thearusable
Copy link

@JacobDomagala @stmcgovern Zoltan contains also a directory called siMPI (src/zoltan/siMPI) which contains many MPI related source files and they look like a copy of MPI library. There are a various MPI related functions and MPI_COMM_WORLD is used in couple of places. Should this PR also include the changes in siMPI or that is something that should be left as it is?

@stmcgovern
Copy link

@JacobDomagala @stmcgovern Zoltan contains also a directory called siMPI (src/zoltan/siMPI) which contains many MPI related source files and they look like a copy of MPI library. There are a various MPI related functions and MPI_COMM_WORLD is used in couple of places. Should this PR also include the changes in siMPI or that is something that should be left as it is?

Thanks for picking this up @thearusable . In my opinion, I think that we should not touch siMPI.

JacobDomagala
JacobDomagala previously approved these changes Aug 11, 2023
JacobDomagala
JacobDomagala previously approved these changes Aug 16, 2023
@JacobDomagala JacobDomagala force-pushed the 42-zoltan-assess-mpi_comm_world-usage-and-implement-a-getter branch from bbf804a to 1ba29cd Compare August 25, 2023 18:52
@thearusable
Copy link

@JacobDomagala The global comm header is installed properly

@JacobDomagala JacobDomagala merged commit 31cf8ca into NGA-FY23-develop Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoltan: Assess MPI_COMM_WORLD usage and implement a getter
4 participants