#62: Speed up file upload #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cwschilly
force-pushed
the
62-speed-up-file-upload
branch
from
a3df782 to
a458aa8
Compare
|
There's a bug in the slicing analysis pipeline. To recreate, try to show the slice lines on the Events Plot |
|
@cwschilly I was able to replicate the bug with the 120 rank CabanaMD data, not the 4 rank |
|
@cwschilly I'm also pushing the updated |
cwschilly
force-pushed
the
62-speed-up-file-upload
branch
from
10205f1 to
06d0ad6
Compare
cwschilly
force-pushed
the
62-speed-up-file-upload
branch
from
06d0ad6 to
c033a6e
Compare
stmcgovern
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Fixes #70
Current solution: distribute file upload, wait until everything is uploaded, then distribute processing.
Outcome: MD 250 case uploads & processes in 65 seconds
More substantial improvements/changes will need to be made in Phase 2 to scale the app well.
Note: The investigation of streaming vs. writing has been moved to PR #72