Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR: Metadata Support #299

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

IR: Metadata Support #299

wants to merge 21 commits into from
+1,079 −65

Conversation

jaylikesbunda
Copy link
Contributor

@jaylikesbunda jaylikesbunda commented Nov 15, 2024 •
edited
Loading

What's new

  • added support for storing, reading and editing metadata for .ir files

Format Example

# Brand: Samsung
# Device Type: TV
# Model: UN55NU7100

QFlipper Screenshots

Screenshot-20241116-asdasdasdasd
Screenshot-20241117-050003
Screenshot-20241116-134128
Screenshot-20241115-173003
Screenshot-20241116-134145

TODO

  • Autofill existing metadata in text input
  • Add more metadata fields
  • Separate "Contribute IR" button to trigger metadata entry flow
  • Fix whatever I'm not freeing in memory + refactor

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@jaylikesbunda jaylikesbunda marked this pull request as ready for review November 16, 2024 06:04
@jaylikesbunda jaylikesbunda changed the title Infrared File Metadata Options Infrared Metadata Nov 16, 2024
@jaylikesbunda jaylikesbunda marked this pull request as draft November 16, 2024 21:03
@jaylikesbunda
fix mem leak
799b9fc 
add missing IR component cleanups and reorder thread cleanup
@jaylikesbunda
refactor
abe82b2
@jaylikesbunda
add back library log
bf1d5bf
@jaylikesbunda jaylikesbunda marked this pull request as ready for review November 17, 2024 05:38
@jaylikesbunda jaylikesbunda changed the title Infrared Metadata IR: Metadata Nov 17, 2024
@jaylikesbunda jaylikesbunda changed the title IR: Metadata IR: Metadata Support Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Awaiting requested review from Willy-JL Willy-JL is a code owner

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaylikesbunda @Willy-JL