Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version labels for all internal charts #351

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

saansh45
Copy link
Contributor

@saansh45 saansh45 commented Dec 3, 2024

This is follow up PR to #350. This just updates the label names to match kubernetes standards.

$ diff -u -b orig new
--- orig	2024-12-03 17:20:49
+++ new	2024-12-03 17:17:01
@@ -3,12 +3,12 @@
 Hang tight while we grab the latest from your chart repositories...
 ...Successfully got an update from the "flink-operator" chart repository
 ...Successfully got an update from the "codimd" chart repository
-...Successfully got an update from the "kedacore" chart repository
 ...Successfully got an update from the "strimzi" chart repository
+...Successfully got an update from the "kedacore" chart repository
 ...Successfully got an update from the "k8s-charts" chart repository
 ...Successfully got an update from the "jetstack" chart repository
-...Successfully got an update from the "fairwinds-stable" chart repository
 ...Successfully got an update from the "argo" chart repository
+...Successfully got an update from the "fairwinds-stable" chart repository
 Update Complete. ⎈Happy Helming!⎈
 Saving 2 charts
 Downloading istio-alerts from repo https://k8s-charts.nextdoor.com
@@ -25,9 +25,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 spec:
@@ -49,7 +49,7 @@
 metadata:
   name: simple-app-ingress
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
@@ -86,9 +86,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 spec:
@@ -109,9 +109,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 ---
@@ -129,7 +129,7 @@
 metadata:
   name: simple-app
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
@@ -162,7 +162,7 @@
 metadata:
   name: simple-app-metrics
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
@@ -191,9 +191,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 spec:
@@ -251,9 +251,9 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: simple-app
         app.kubernetes.io/version: latest
-        helm.sh/chart: simple-app-1.12.4
-        helm.sh/chartName: simple-app
-        helm.sh/chartVersion: 1.12.4
+        helm.sh/chart: simple-app-1.12.5
+        helm.sh/chart-name: simple-app
+        helm.sh/chart-version: 1.12.5
         tags.datadoghq.com/service: simple-app
         tags.datadoghq.com/version: latest
         sidecar.istio.io/inject: "true"
@@ -349,9 +349,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 spec:
@@ -400,9 +400,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
   annotations:
@@ -512,9 +512,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: simple-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: simple-app-1.12.4
-    helm.sh/chartName: simple-app
-    helm.sh/chartVersion: 1.12.4
+    helm.sh/chart: simple-app-1.12.5
+    helm.sh/chart-name: simple-app
+    helm.sh/chart-version: 1.12.5
     tags.datadoghq.com/service: simple-app
     tags.datadoghq.com/version: latest
 spec:
@@ -710,7 +710,7 @@
 metadata:
   name: simple-app-monitor-rules
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
@@ -734,7 +734,7 @@
 metadata:
   name: simple-app
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
@@ -778,7 +778,7 @@
 metadata:
   name: "simple-app-test-connection"
   labels:
-    helm.sh/chart: simple-app-1.12.4
+    helm.sh/chart: simple-app-1.12.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "simple-app"
$ diff -u -b orig new
--- orig	2024-12-03 17:21:09
+++ new	2024-12-03 17:17:19
@@ -1,12 +1,12 @@
 Pulling dependencies in...
 helm dependency update .
 Hang tight while we grab the latest from your chart repositories...
-...Successfully got an update from the "codimd" chart repository
 ...Successfully got an update from the "flink-operator" chart repository
+...Successfully got an update from the "codimd" chart repository
 ...Successfully got an update from the "kedacore" chart repository
 ...Successfully got an update from the "strimzi" chart repository
-...Successfully got an update from the "jetstack" chart repository
 ...Successfully got an update from the "k8s-charts" chart repository
+...Successfully got an update from the "jetstack" chart repository
 ...Successfully got an update from the "argo" chart repository
 ...Successfully got an update from the "fairwinds-stable" chart repository
 Update Complete. ⎈Happy Helming!⎈
@@ -25,9 +25,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
 spec:
@@ -53,9 +53,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
 spec:
@@ -76,9 +76,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
 ---
@@ -88,7 +88,7 @@
 metadata:
   name: stateful-app
   labels:
-    helm.sh/chart: stateful-app-1.4.4
+    helm.sh/chart: stateful-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "stateful-app"
@@ -121,7 +121,7 @@
 metadata:
   name: stateful-app-metrics
   labels:
-    helm.sh/chart: stateful-app-1.4.4
+    helm.sh/chart: stateful-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "stateful-app"
@@ -150,9 +150,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
 spec:
@@ -211,9 +211,9 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: stateful-app
         app.kubernetes.io/version: latest
-        helm.sh/chart: stateful-app-1.4.4
-        helm.sh/chartName: stateful-app
-        helm.sh/chartVersion: 1.4.4
+        helm.sh/chart: stateful-app-1.4.5
+        helm.sh/chart-name: stateful-app
+        helm.sh/chart-version: 1.4.5
         tags.datadoghq.com/service: stateful-app
         tags.datadoghq.com/version: latest
         sidecar.istio.io/inject: "true"
@@ -302,9 +302,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
   annotations:
@@ -414,9 +414,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: stateful-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: stateful-app-1.4.4
-    helm.sh/chartName: stateful-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: stateful-app-1.4.5
+    helm.sh/chart-name: stateful-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: stateful-app
     tags.datadoghq.com/version: latest
 spec:
@@ -615,7 +615,7 @@
 metadata:
   name: stateful-app-monitor-rules
   labels:
-    helm.sh/chart: stateful-app-1.4.4
+    helm.sh/chart: stateful-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "stateful-app"
@@ -639,7 +639,7 @@
 metadata:
   name: stateful-app
   labels:
-    helm.sh/chart: stateful-app-1.4.4
+    helm.sh/chart: stateful-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "stateful-app"
@@ -683,7 +683,7 @@
 metadata:
   name: "stateful-app-test-connection"
   labels:
-    helm.sh/chart: stateful-app-1.4.4
+    helm.sh/chart: stateful-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "stateful-app"
$ diff -u -b orig new
--- orig	2024-12-03 17:21:02
+++ new	2024-12-03 17:17:25
@@ -1,8 +1,8 @@
 Pulling dependencies in...
 helm dependency update .
 Hang tight while we grab the latest from your chart repositories...
-...Successfully got an update from the "codimd" chart repository
 ...Successfully got an update from the "flink-operator" chart repository
+...Successfully got an update from the "codimd" chart repository
 ...Successfully got an update from the "kedacore" chart repository
 ...Successfully got an update from the "strimzi" chart repository
 ...Successfully got an update from the "k8s-charts" chart repository
@@ -25,9 +25,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 spec:
@@ -49,7 +49,7 @@
 metadata:
   name: rollout-app-ingress
   labels:
-    helm.sh/chart: rollout-app-1.4.4
+    helm.sh/chart: rollout-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "rollout-app"
@@ -86,9 +86,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 spec:
@@ -109,9 +109,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 ---
@@ -133,9 +133,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
   annotations:
@@ -167,9 +167,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
   annotations:
@@ -201,9 +201,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 spec:
@@ -252,9 +252,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
   annotations:
@@ -278,7 +278,7 @@
 metadata:
   name: rollout-app
   labels:
-    helm.sh/chart: rollout-app-1.4.4
+    helm.sh/chart: rollout-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "rollout-app"
@@ -399,7 +399,7 @@
 metadata:
   name: rollout-app-monitor-rules
   labels:
-    helm.sh/chart: rollout-app-1.4.4
+    helm.sh/chart: rollout-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "rollout-app"
@@ -427,9 +427,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 spec:
@@ -611,9 +611,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: rollout-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: rollout-app-1.4.4
-    helm.sh/chartName: rollout-app
-    helm.sh/chartVersion: 1.4.4
+    helm.sh/chart: rollout-app-1.4.5
+    helm.sh/chart-name: rollout-app
+    helm.sh/chart-version: 1.4.5
     tags.datadoghq.com/service: rollout-app
     tags.datadoghq.com/version: latest
 spec:
@@ -676,9 +676,9 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: rollout-app
         app.kubernetes.io/version: latest
-        helm.sh/chart: rollout-app-1.4.4
-        helm.sh/chartName: rollout-app
-        helm.sh/chartVersion: 1.4.4
+        helm.sh/chart: rollout-app-1.4.5
+        helm.sh/chart-name: rollout-app
+        helm.sh/chart-version: 1.4.5
         tags.datadoghq.com/service: rollout-app
         tags.datadoghq.com/version: latest
         sidecar.istio.io/inject: "true"
@@ -761,7 +761,7 @@
 metadata:
   name: "rollout-app-test-connection"
   labels:
-    helm.sh/chart: rollout-app-1.4.4
+    helm.sh/chart: rollout-app-1.4.5
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "rollout-app"
$ diff -u -b orig new
--- orig	2024-12-03 17:20:58
+++ new	2024-12-03 17:17:13
@@ -5,10 +5,10 @@
 ...Successfully got an update from the "codimd" chart repository
 ...Successfully got an update from the "kedacore" chart repository
 ...Successfully got an update from the "strimzi" chart repository
-...Successfully got an update from the "k8s-charts" chart repository
 ...Successfully got an update from the "jetstack" chart repository
-...Successfully got an update from the "argo" chart repository
+...Successfully got an update from the "k8s-charts" chart repository
 ...Successfully got an update from the "fairwinds-stable" chart repository
+...Successfully got an update from the "argo" chart repository
 Update Complete. ⎈Happy Helming!⎈
 Saving 1 charts
 Deleting outdated charts
@@ -20,7 +20,7 @@
 metadata:
   name: daemonset-app-ingress
   labels:
-    helm.sh/chart: daemonset-app-0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "daemonset-app"
@@ -50,9 +50,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: daemonset-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: daemonset-app-0.16.1
-    helm.sh/chartName: daemonset-app
-    helm.sh/chartVersion: 0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
+    helm.sh/chart-name: daemonset-app
+    helm.sh/chart-version: 0.16.2
     tags.datadoghq.com/service: daemonset-app
     tags.datadoghq.com/version: latest
 ---
@@ -62,7 +62,7 @@
 metadata:
   name: daemonset-app
   labels:
-    helm.sh/chart: daemonset-app-0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "daemonset-app"
@@ -91,7 +91,7 @@
 metadata:
   name: daemonset-app-metrics
   labels:
-    helm.sh/chart: daemonset-app-0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "daemonset-app"
@@ -120,9 +120,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: daemonset-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: daemonset-app-0.16.1
-    helm.sh/chartName: daemonset-app
-    helm.sh/chartVersion: 0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
+    helm.sh/chart-name: daemonset-app
+    helm.sh/chart-version: 0.16.2
     tags.datadoghq.com/service: daemonset-app
     tags.datadoghq.com/version: latest
 spec:
@@ -159,9 +159,9 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: daemonset-app
         app.kubernetes.io/version: latest
-        helm.sh/chart: daemonset-app-0.16.1
-        helm.sh/chartName: daemonset-app
-        helm.sh/chartVersion: 0.16.1
+        helm.sh/chart: daemonset-app-0.16.2
+        helm.sh/chart-name: daemonset-app
+        helm.sh/chart-version: 0.16.2
         tags.datadoghq.com/service: daemonset-app
         tags.datadoghq.com/version: latest
         sidecar.istio.io/inject: "false"
@@ -236,9 +236,9 @@
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: daemonset-app
     app.kubernetes.io/version: latest
-    helm.sh/chart: daemonset-app-0.16.1
-    helm.sh/chartName: daemonset-app
-    helm.sh/chartVersion: 0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
+    helm.sh/chart-name: daemonset-app
+    helm.sh/chart-version: 0.16.2
     tags.datadoghq.com/service: daemonset-app
     tags.datadoghq.com/version: latest
 spec:
@@ -436,7 +436,7 @@
 metadata:
   name: daemonset-app-monitor-rules
   labels:
-    helm.sh/chart: daemonset-app-0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "daemonset-app"
@@ -460,7 +460,7 @@
 metadata:
   name: daemonset-app
   labels:
-    helm.sh/chart: daemonset-app-0.16.1
+    helm.sh/chart: daemonset-app-0.16.2
     app.kubernetes.io/version: "latest"
     app.kubernetes.io/managed-by: Helm
     tags.datadoghq.com/service: "daemonset-app"

@diranged
Copy link
Contributor

diranged commented Dec 3, 2024

I'm fine with this.. doesn't really matter to me whether its camelCase or dash-case. See #350 (comment) though and my comment about not really needing our own label namespace (which you didn't do here anyways)

Copy link
Contributor

@diranged diranged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like this is better, I'm fine with it... no strong opinion here.

@saansh45 saansh45 merged commit aea70b7 into main Dec 3, 2024
2 checks passed
@saansh45 saansh45 deleted the update_label_name branch December 3, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants