-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTM #7
Conversation
WalkthroughThis update introduces Google Tag Manager to the website by adding relevant script and noscript elements to the HTML document. This addition is aimed at enhancing tracking capabilities, allowing for a more detailed analysis of user interactions and website performance. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Visit the preview URL for this PR (updated for commit 7575651): https://nibiru-explorer--pr7-chore-gtm-ewdpp5pw.web.app (expires Thu, 21 Mar 2024 20:39:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0653a911498be5ff7b1517207d84ddca0bcce10b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- index.html (2 hunks)
Additional comments: 1
index.html (1)
- 27-37: The noscript tag for GTM has been correctly added for environments where JavaScript is disabled. This ensures that tracking capabilities are still partially available in such cases. However, there are a couple of points to consider:
- Accessibility: Ensure that the use of an iframe within a noscript tag does not negatively impact the accessibility of your website. While the iframe is hidden and has a size of 0, it's good practice to verify that it doesn't interfere with screen readers or other assistive technologies.
- Privacy Compliance: Similar to the script tag, ensure that the use of GTM complies with privacy laws and that necessary consent is obtained for users, especially when tracking is possible without JavaScript enabled.
Summary by CodeRabbit