fix(resolve rabbit comments): comments

NibiruChain · Nov 30, 2023 · 69ccefa · 69ccefa
1 parent 5690d98
commit 69ccefa
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/packages/nibijs/docs/classes/StableSwap.md b/packages/nibijs/docs/classes/StableSwap.md
@@ -178,7 +178,7 @@ y()
 Calculate x[j] if one makes x[i] = x
 
 Done by solving quadratic equation iteratively.
-x*1\*\*2 + x1 * (sum' - (A*n\*\*n - 1) * D / (A _ n**n)) = D ** (n+1)/(n \*\* (2 _ n) \_ prod' \* A)
+x*1\*\*2 + x1 * (sum' - (A*n\*\*n - 1) * D / (A _ n**n)) = D ** (n+1)/(n \*\* (2 _ n) _ prod' _ A)
 x_1\*\*2 + b\*x_1 = c
 
 x_1 = (x_1\**2 + c) / (2*x_1 + b)

diff --git a/packages/nibijs/src/query/perp.ts b/packages/nibijs/src/query/perp.ts
@@ -32,6 +32,16 @@ export interface PerpExtension {
   }>
 }
 
+const transformPositions = (
+  resp: QueryPositionsResponse
+): QueryPositionsResponse => {
+  const { positions } = resp
+  resp.positions = positions.map((position: QueryPositionResponse) =>
+    transformPosition(position)
+  )
+  return resp
+}
+
 export function setupPerpExtension(base: QueryClient): PerpExtension {
   const rpcClient = createProtobufRpcClient(base)
   const queryService = new QueryClientImpl(rpcClient)
@@ -52,22 +62,11 @@ export function setupPerpExtension(base: QueryClient): PerpExtension {
         const req = QueryPositionsRequest.fromPartial(args)
         const resp = await queryService.QueryPositions(req)
 
-        function transformPositions(
-          resp: QueryPositionsResponse
-        ): QueryPositionsResponse {
-          const { positions } = resp
-          resp.positions = positions.map((position: QueryPositionResponse) =>
-            transformPosition(position)
-          )
-          return resp
-        }
-
         return transformPositions(resp)
       },
       markets: async () => {
         const req = QueryMarketsRequest.fromPartial({})
-        const resp = queryService.QueryMarkets(req)
-        return resp
+        return queryService.QueryMarkets(req)
       },
     },
   }

diff --git a/packages/nibijs/src/test/query.tests/perp.test.ts b/packages/nibijs/src/test/query.tests/perp.test.ts
@@ -74,9 +74,9 @@ describe("setupPerpExtension", () => {
         trader: "Test Trader",
       })
       expect(result).toEqual({
-        positionNotional: "1e-16",
-        unrealizedPnl: "5e-17",
-        marginRatio: "5e-18",
+        positionNotional: "100",
+        unrealizedPnl: "50",
+        marginRatio: "5",
       })
     })
   })

diff --git a/packages/nibijs/src/tx/signingClient.test.ts b/packages/nibijs/src/tx/signingClient.test.ts
@@ -208,7 +208,7 @@ describe("nibid tx perp", () => {
       expect(txLogs).toHaveLength(1)
 
       // perp tx close-position events
-      assertHasMsgType("MsgClosePosition", txLogs[0].events)
+      assertHasMsgType(PERP_MSG_TYPE_URLS.MsgClosePosition, txLogs[0].events)
       assertHasEventType(
         "nibiru.perp.v1.PositionChangedEvent",
         txLogs[0].events