Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gql staking #347

Closed
wants to merge 4 commits into from
Closed

feat: gql staking #347

wants to merge 4 commits into from

Conversation

ruslan-sh-r
Copy link
Contributor

@ruslan-sh-r ruslan-sh-r commented Apr 23, 2024

Summary by CodeRabbit

  • Refactor
    • Consolidated various delegation and bonding queries into a unified staking functionality.
  • New Features
    • Introduced new staking query capabilities to enhance user interactions with staking operations.
  • Bug Fixes
    • Removed unused code elements to streamline operations and improve performance.

Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent update simplifies the GraphQL schema by removing various entities related to delegations, redelegations, unbondings, and validators while introducing a consolidated 'staking' entity. This change enhances efficiency and focuses on core staking functionalities.

Changes

Files Change Summary
.../heart-monitor.test.ts, .../heart-monitor.ts Removed multiple delegation-related entities; added staking-related entities and functions.
src/gql/query/index.ts Replaced delegations, redelegations, unbondings, validators modules with a single staking module.
src/gql/query/staking.ts Introduced new file for querying staking-related data.
src/gql/utils/defaultObjects.ts Removed declarations for GQLDelegation, GQLRedelegation, GQLUnbonding.
src/gql/utils/consts.test.ts Modified queryBatchHandler test to focus only on communityPool data retrieval, removing delegations logic.
src/gql/utils/consts.ts Added checkNoFields function.

🐇✨
Oh hoppity hop, the code does clean,
Away old clutter, the new is seen!
Staking here, in fields so wide,
Simplified queries, with nowhere to hide.
Cheers to fresh starts, on this coding spree,
With every commit, more bugs flee! 🌟
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 65701df and 4cf6d19.
Files selected for processing (1)
  • src/gql/utils/consts.test.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/gql/utils/consts.test.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 23, 2024

Lines Statements Branches Functions
Coverage: 87%
89.03% (1031/1158) 70.49% (411/583) 76.63% (246/321)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

src/gql/utils/consts.ts Show resolved Hide resolved
@cgilbe27
Copy link
Contributor

One last comment and it will look good to me, can we keep the default objects still?
Even if they need to be explicitly defined, and not in use, there are some cases where we do need all fields, and would like to reference those objects

Otherwise, looks good to me

@cgilbe27
Copy link
Contributor

cgilbe27 commented May 7, 2024

Superseded by #350

@cgilbe27 cgilbe27 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants