Split get_score into get_score and get_lazer_score #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i didnt get a notif for this pr u should have told me abt it |
NiceAesth
requested changes
Nov 2, 2024
|
|
||
| :raises APIException: Contains status code and error message | ||
| :raises RefreshTokenExpiredError: If the client refresh token has expired | ||
| :return: Score data object | ||
| :rtype: aiosu.models.score.Score | ||
| """ | ||
| url = f"{self.base_url}/api/v2/scores/{mode}/{score_id}" | ||
| headers = {} | ||
| new_format = kwargs.pop("new_format", False) |
There was a problem hiding this comment.
the new_format logic should still remain in both methods to not break existing shit
this stuff should only be removed when the library fully switches to new api models
aiosu/v2/client.py
Outdated
| @@ -1761,37 +1761,47 @@ async def get_score( | |||
| self, | |||
| score_id: int, | |||
| mode: Gamemode, | |||
| **kwargs: Any, | |||
| ) -> Union[Score, LazerScore]: | |||
| ) -> Score: | |||
| r"""Gets data about a score. | |||
|
|
|||
| :param score_id: The ID of the score | |||
There was a problem hiding this comment.
Suggested change
| :param score_id: The ID of the score | |
| :param legacy_score_id: The ID of the score |
potentially
|
also needs a new test added ill probably handle that myself unless you want to try and do it |
NiceAesth
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd suggest testing it in case i messed up somewhere
Self-check