Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment rework #221

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GingerAvalanche
Copy link
Collaborator

Adds a new setting to the deployment config (so it's set on a per-console basis) called DeployLayout, which allows the user to set whether they want to add a ukmm-named folder to their output folder.

Using the DeployLayout setting, ukmm will either add or not add a BreathOfTheWild_UKMM folder to the output path in the appropriate location based on the console.

  • For WiiU, this will make sure that even if the user selects the root graphic pack folder as their output folder, ukmm will still deploy to a folder unique to it.
  • For Switch emulators, this will allow the user to deploy to either the atmosphere layeredfs location or the built-in mod manager, depending on which option they choose.

By default, the DeployLayout will be WithoutName, which will behave exactly as ukmm did in previous versions (and as bcml did) except that, on WiiU in symlink deploy mode, links will be created to the content and aoc folders, instead of to their containing folder. This also happens to solve a minor inconvenience where people could accidentally delete their graphic packs by setting the root graphic pack folder as their output folder - if they do that, Cemu still won't work right, but at least their graphic pack folder won't be deleted.

Docs have been updated to reflect the new setting.

Better implementation of (and obsoletes) #204
Addresses and closes... some issue. I could swear there was one. If I can find it, I'll link it so that it'll close when this gets pulled

@GingerAvalanche
Copy link
Collaborator Author

As with #204, I can't test the Switch side of this on my own. I have tested the WiiU side and verified that both With Name and Without Name work as expected, and that the option default will allow ukmm to continue working as it did before, even if existing users upgrade without touching (or even knowing about) the setting.

@GingerAvalanche
Copy link
Collaborator Author

In-game testing has revealed that, while the paths are visually identical, they are not functionally identical in relation to Cemu. Cemu will only read links in the root folder of a graphic pack, so I'm going to change the behavior from copying the 0010 folder to copying the aoc folder (which will only ever have 0010 in it anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant