Fix issue when detecting if slide is visible

The last slide offset was ceiled before comparing it to the dimensions of the container which could cause problems when viewport size could lead to the item end offset being 1px off. Instead we floor the number to make sure it doesn't add that extra pixel. Fixes #40
NickPiscitelli · May 28, 2019 · b102ce2 · b102ce2
1 parent c22d1fa
commit b102ce2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/assets/js/glider.min.js b/docs/assets/js/glider.min.js
diff --git a/glider.js b/glider.js
@@ -296,7 +296,7 @@
       }
 
       var isVisible =
-        Math.ceil(itemStart) >= start && Math.ceil(itemEnd) <= end
+        Math.ceil(itemStart) >= start && Math.floor(itemEnd) <= end
       slideClasses.toggle('visible', isVisible)
       if (isVisible !== wasVisible) {
         _.emit('slide-' + (isVisible ? 'visible' : 'hidden'), {