Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database size on status page #3759

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Nov 6, 2024

This PR adds a new item to classic status page, the database size.
It removes the phrase "downgradable to" from the same status page.

Before After
xDrip-Status-Screenshot-2024-11-05-21-53-00 xDrip-Status-Screenshot-2024-11-05-23-07-26

@jamorham
Copy link
Collaborator

jamorham commented Nov 8, 2024

I think this is very messy what you're doing here. You're trying to use asynchronous features synchronously and creating a lot of weight for something that really doesn't need to be that complicated. See the new utility method I have provided for this. I suggest completely reworking this PR to just use that: 53507c7

@Navid200
Copy link
Collaborator Author

Navid200 commented Nov 8, 2024

Thanks you so much.
Will be done.

@Navid200
Copy link
Collaborator Author

Navid200 commented Nov 8, 2024

Thanks for the guidance.
It should be good now.
Thanks

@jamorham jamorham merged commit 11a4803 into NightscoutFoundation:master Nov 15, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2023_09_25 branch November 16, 2024 00:13
@olorinmaia
Copy link
Contributor

@Navid200 What is the use-case that benefit of knowing database size?

@Navid200
Copy link
Collaborator Author

@olorinmaia If you have been using xDrip for years, the database may contain data you will never need inside xDrip any longer. Keeping data in xDrip corresponding to 20 years ago is not necessary.

I welcome suggestions as to what could be the cause of this: #1280
In the meantime, I would suggest to everyone to avoid allowing their database to unnecessarily grow.

Being able to see the size of the database can be useful for deciding when you may want to do some cleanup.

@olorinmaia
Copy link
Contributor

Thanks for some info regarding this. If database cleaning is necessary, is this the way or is there other methods?
https://navid200.github.io/xDrip/docs/Backup/SaveDaily.html
I mean setting Glucose retention to e.g. 365.

@Navid200
Copy link
Collaborator Author

Thanks for some info regarding this. If database cleaning is necessary, is this the way or is there other methods? https://navid200.github.io/xDrip/docs/Backup/SaveDaily.html I mean setting Glucose retention to e.g. 365.

Thanks for that link. I will need to update that.

Yes, setting glucose retention to a value like 365 is a way to limit the size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants