QnA Conversational Agent #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @hiteshhhh007 add a .ipynb file instead of .py, with proper comments. And improve your readme. md file. you can take reference of other readme added in this project. |
|
@invigorzz313 @Niketkumardheeryan I have made the changes, kindly merge this request |
|
@hiteshhhh007 LGTM but since you have changed the file type as .ipynb, you may also want to edit the ReadMe.md file and the main file wherever there are .py files mentioned..? |
|
yup, can you check now, I have updated the readme.md, the main files are already in .ipynb.. |
|
@invigorzz313 @Niketkumardheeryan , hey please look at this, kindly merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Issue559 Resolved!
@Niketkumardheeryan
I have attached the code. Please consider my pull request under GSSoC'24.