Per Entity SpatialRadius for controlling spatial audio ranges
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imo there's no good reason to place the logic on a method of the `GlobalSpatialRadius` anymore
NiklasEi
reviewed
Nov 30, 2024
| pub struct SpatialAudio { | ||
| /// The volume will change from `1` at distance `0` to `0` at distance `max_distance` | ||
| pub max_distance: f32, | ||
| pub struct GlobalSpatialRadius { |
There was a problem hiding this comment.
This resource would make more sense as a field on SpatialAudioPlugin. E.g. default_spatial_audio_radius.
| }); | ||
| } | ||
|
|
||
| fn spatial_audio_enabled( |
There was a problem hiding this comment.
This means the system won't run without the resource, even if all emitters have their own SpacialRadius components.
I think it would be more idiomatic to just let users add the SpatialAudioPlugin.
| /// If neither this component or the [`GlobalSpatialRadius`] resource exists in the ECS, spatial | ||
| /// audio is not applied. | ||
| #[derive(Component)] | ||
| pub struct SpatialRadius { |
There was a problem hiding this comment.
Maybe SpatialRadius could be a required component of AudioEmitter? If so, the default value could not be changed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was one of the first things that naturally seemed to be missing. This basically tackles #121.
I updated the example, so now the cooking pot is only hearable if you're really closeby while you can still listen to the radio from a greater distance.
There were a few other small changes I made when working on this. I just couldn't help but make the code here and there more idiomic.