Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kira to 0.9 #131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Kira to 0.9 #131

wants to merge 2 commits into from

Conversation

benknowles
Copy link
Contributor

Updated Kira to 0.9.

In the latest, they made it audio commands do not fail, so the CommandError handling could be removed.

Also, the playback_region was changed to a "slice" on the StaticSoundData.

NiklasEi
NiklasEi reviewed Nov 30, 2024
View reviewed changes
Copy link
Owner

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some changes seem to be missing for the settings_loader feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benknowles @NiklasEi