Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tooling to pnpm, biome, lefthook and vitest #32

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Migrate tooling to pnpm, biome, lefthook and vitest #32

merged 13 commits into from
Nov 4, 2024

Conversation

tim-hm
Copy link
Collaborator

@tim-hm tim-hm commented Nov 4, 2024

No description provided.

@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch from 1986170 to ecb66cd Compare November 4, 2024 10:03
@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch 2 times, most recently from 3626438 to a27ff1b Compare November 4, 2024 12:06
@tim-hm
feat: replace eslint with biome lint
8fcb881
@tim-hm
feat: replace husky with lefthook for git hooks
9e7908e
@tim-hm
feat: replace jest with vitest
3343bbd 
This change necessitated several other changes which are worth calling out:

- Vitest will automatically load the environment from `.env.test` so that is now included
- Because commands were simplified, the justfile now adds more noise than value and so its been removed
- The root tsconfig was there to support eslint, but it is not needed for biome. So it was removed, and now each project can have a convenience aliases to avoid relative imports that go up the directory structure (eg. `../../foo` is now `#/foo`).
@tim-hm
ci(client-vms): enable tests
7153d5e
@tim-hm
chore: fix biome lint and tsc issues from tooling changes
9073654
@tim-hm
refactor: lift test nada programs for improved visibility
d16b097
@tim-hm
ci: add AWS credentials so nilup can access rc builds
15ff7e4
@tim-hm
ci(client-vms): enable test coverage report
1a09b8b
@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch from a27ff1b to 1a09b8b Compare November 4, 2024 12:07
@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch 13 times, most recently from d5ae69a to 3d67f51 Compare November 4, 2024 14:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Coverage Report for ./client-vms

Status Category Percentage Covered / Total
🔵 Lines 88.36% 1572 / 1779
🔵 Statements 88.36% 1572 / 1779
🔵 Functions 84.87% 174 / 205
🔵 Branches 90.19% 230 / 255
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
client-vms/src/auth.ts 98.78% 93.33% 100% 98.78% 92
client-vms/src/util.ts 57.14% 40% 100% 57.14% 3-4, 8-9, 12-13
client-vms/src/gen-proto/nillion/auth/v1/public_key_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/auth/v1/token_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/auth/v1/user_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/compute/v1/invoke_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/compute/v1/retrieve_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/compute/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/compute/v1/stream_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/leader_queries/v1/pool_status_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/leader_queries/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/membership/v1/cluster_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/membership/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/meta/v1/tx_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/quote_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/receipt_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/payments/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/permissions/v1/overwrite_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/permissions/v1/permissions_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/permissions/v1/retrieve_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/permissions/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/permissions/v1/update_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/preprocessing/v1/cleanup_pb.ts 0% 0% 0% 0% 1-50
client-vms/src/gen-proto/nillion/preprocessing/v1/element_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/preprocessing/v1/generate_pb.ts 0% 0% 0% 0% 1-114
client-vms/src/gen-proto/nillion/preprocessing/v1/service_pb.ts 0% 0% 0% 0% 1-59
client-vms/src/gen-proto/nillion/preprocessing/v1/stream_pb.ts 0% 0% 0% 0% 1-56
client-vms/src/gen-proto/nillion/programs/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/programs/v1/store_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/values/v1/delete_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/values/v1/retrieve_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/values/v1/service_pb.ts 100% 100% 100% 100%
client-vms/src/gen-proto/nillion/values/v1/store_pb.ts 100% 100% 100% 100%
client-vms/src/payment/builder.ts 96.15% 80% 100% 96.15% 49-50
client-vms/src/payment/client.ts 100% 100% 100% 100%
client-vms/src/payment/grpc-compat.ts 94.28% 100% 66.66% 94.28% 46-47
client-vms/src/payment/wallet.ts 36.66% 100% 50% 36.66% 14-35
client-vms/src/types/compute-permission-command.ts 54.71% 100% 71.42% 54.71% 19-22, 25-28, 41-48, 51-58
client-vms/src/types/grpc.ts 100% 100% 100% 100%
client-vms/src/types/permission-command.ts 66.66% 87.5% 75% 66.66% 22-26, 36-43, 47-50
client-vms/src/types/types.ts 100% 100% 100% 100%
client-vms/src/types/user-id.ts 68% 80% 80% 68% 12-15, 19-22
client-vms/src/types/values-permissions.ts 69.73% 90.9% 40% 69.73% 45-46, 54-59, 62-64, 67-69, 72-74, 77-79, 82-84
client-vms/src/vm/builder.ts 88.42% 82.35% 88.88% 88.42% 47-49, 102-104, 106-111, 120-121
client-vms/src/vm/client.ts 100% 100% 100% 100%
client-vms/src/vm/operation/delete-values.ts 95.83% 90.9% 100% 95.83% 40-41
client-vms/src/vm/operation/invoke-compute.ts 95.65% 95% 92.3% 95.65% 76-77, 138-140
client-vms/src/vm/operation/overwrite-permissions.ts 100% 100% 100% 100%
client-vms/src/vm/operation/query-pool-status.ts 100% 100% 100% 100%
client-vms/src/vm/operation/retrieve-compute-result.ts 93.1% 87.5% 100% 93.1% 37-40
client-vms/src/vm/operation/retrieve-permissions.ts 100% 100% 100% 100%
client-vms/src/vm/operation/retrieve-values.ts 96.96% 91.66% 100% 96.96% 44-45
client-vms/src/vm/operation/store-program.ts 97.64% 100% 90.9% 97.64% 32-33
client-vms/src/vm/operation/store-values.ts 91.96% 88.88% 85.71% 91.96% 51, 63-64, 134-136, 144-146
client-vms/src/vm/operation/update-permissions.ts 80.73% 100% 58.82% 80.73% 100-102, 105-107, 110-112, 115-117, 120-122, 130-132, 135-137
Generated in workflow #29 for commit 03303cc by the Vitest Coverage Report Action

@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch 2 times, most recently from 2df1fef to 597e3d9 Compare November 4, 2024 14:15
@tim-hm tim-hm force-pushed the timhm/migrate-tooling-to-pnpm-biome branch from 597e3d9 to 03303cc Compare November 4, 2024 14:16
@tim-hm tim-hm merged commit b446a46 into main Nov 4, 2024
2 checks passed
@tim-hm tim-hm deleted the timhm/migrate-tooling-to-pnpm-biome branch November 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tim-hm