ec2: Fix --allow-recreate not recreating terminated spot instances #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I wrote and tested this patch for NixOps 1.7, I haven't tested it on |
Until now, `nixops deploy --check --allow-recreate` would fail to
recreate terminated spot instances, instead emitting the error:
Exception: spot instance request got fulfilled unexpectedly as instance ‘i-0543dd70c68337dea’
This was because `_reset_state()` did not reset the
`self._cached_instance`, and so the `_get_instance()` call in
`create_instance()` would continue to refer to the ID of the disappeared
instance, eventually producing the error.
nh2
force-pushed
the
fix-allow-recreate-on-spot-instances
branch
from
bbe427b to
085c7a2
Compare
nh2
changed the title
|
I just tested it after manually cancelling a spot request and terminating the instance but it failed throwing this error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now,
nixops deploy --check --allow-recreatewould fail torecreate terminated spot instances, instead emitting the error:
This was because
_reset_state()did not reset theself._cached_instance, and so the_get_instance()call increate_instance()would continue to refer to the ID of the disappearedinstance, eventually producing the error.