crackle: init at unstable-2020-12-13 #124172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
Result of 1 package built:
|
fabaff
reviewed
May 23, 2021
|
|
||
| stdenv.mkDerivation { | ||
| pname = "crackle"; | ||
| version = "unstable-2020-12-13"; |
There was a problem hiding this comment.
Let's see if can get a proper release: mikeryan/crackle#50
|
|
||
| src = fetchFromGitHub { | ||
| owner = "mikeryan"; | ||
| repo = "crackle"; |
There was a problem hiding this comment.
Opinionated change
Suggested change
| repo = "crackle"; | |
| repo = pname; |
|
Result of 1 package built:
|
fabaff
approved these changes
May 26, 2021
There was a problem hiding this comment.
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.maintainersis set - package built (see crackle: init at unstable-2020-12-13 #124172 (comment))
- all depending packages build
- tested on x86_64
...ew/pr-124172]$ ./results/crackle/bin/crackle
Usage: crackle -i <input.pcap> [-o <output.pcap>] [-l <ltk>] [-s]
Cracks Bluetooth Low Energy encryption (AKA Bluetooth Smart)
Major modes: Crack TK // Decrypt with LTK
[...] Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#81418
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)