rustc: support clang-based stdenv #257950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were passing `cc` and `c++` all the time to rustc bootstrap process. This was wrong because `cc-rs` relies on the name of the compiler to detect whether this is Clang or a GNU GCC. Related: [1]: https://github.com/rust-lang/cc-rs/blob/df2f86ceafbe787698b890a3d6bde9f969d5fa88/src/lib.rs#L3334 [2]: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Missing.20dynamic.20libraries.20when.20bootstrapping.20Rust/near/377914373
RaitoBezarius
requested review from
Mic92,
zowoq,
winterqt and
figsoda
as code owners
|
Hm, actually, this could go on master as no one is depending on clang stdenvs yet… |
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
|
Hah, it does trigger rebuilds. |
That's horrifying. Can it be fixed? |
I believe it is: rust-lang/cc-rs#709 |
alyssais
reviewed
Oct 3, 2023
|
@RaitoBezarius cc-rs 1.0.84 includes this change, so if we can get rust to update we can drop this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, we were passing
ccandc++all the time to rustc bootstrap process.This was wrong because
cc-rsrelies on the name of the compiler to detect whether this is Clang or a GNU GCC.Related:
https://github.com/rust-lang/cc-rs/blob/df2f86ceafbe787698b890a3d6bde9f969d5fa88/src/lib.rs#L3334
https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Missing.20dynamic.20libraries.20when.20bootstrapping.20Rust/near/377914373
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)