Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyter: fix runtime error #268078

Merged
merged 1 commit into from
Nov 21, 2023
Merged

jupyter: fix runtime error #268078

merged 1 commit into from
Nov 21, 2023

Conversation

natsukium
Copy link
Member

@natsukium natsukium commented Nov 17, 2023 •
edited
Loading

fixes #255923

it occurred because the python runtime environment did not include the jupyter share, etc directories.

I confirmed that the following commands work correctly.

nix run --impure --expr 'with import ./. {}; jupyter.override { definitions.iruby = iruby.definition; }'

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lucasew @fedeinthemix @AKarbas
cc @GaetanLepage @thomasjm

@natsukium
jupyter: fix runtime error
4380257 
fixed a bug reported in NixOS#255923

it occurred because the python runtime environment did not include the
jupyter share, etc directories.
@teto teto added the 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab label Nov 17, 2023
@natsukium natsukium mentioned this pull request Nov 21, 2023
Closed
GaetanLepage
GaetanLepage approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

Thanks for the fix !

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 21, 2023
@thomasjm thomasjm self-requested a review November 21, 2023 22:12
thomasjm
thomasjm approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@thomasjm thomasjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works for me! Thanks!

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 21, 2023
@teto teto merged commit 86eb3a9 into NixOS:master Nov 21, 2023
28 checks passed
@natsukium natsukium deleted the jupyter/fix branch November 22, 2023 00:10
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
1 task
@TyberiusPrime TyberiusPrime mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@thomasjm thomasjm thomasjm approved these changes

Assignees
No one assigned
Labels
6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jupyter: Broken, Schema not found
5 participants
@natsukium @thomasjm @GaetanLepage @delroth @teto