Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_86BoxManagerX: init at 1.7.6.0-e #307611

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Apr 29, 2024

Description of changes

https://github.com/RetBox/86BoxManagerX

86BoxManagerX is a cross-platform fork of 86BoxManager, a configuration manager for 86Box. 86BoxManagerX makes it easy to manage multiple different machine configurations using 86Box.

In order to integrate it well into Nixpkgs, the following patches were made:

  • The configuration file is loaded from $XDG_CONFIG_HOME rather than the directory of the assembly, which would point into the read-only Nix store. This is adapted from a pending pull request.
  • The directory of 86Box is hardcoded into the Nix store.
  • The UI elements and respective logic for changing the path to the 86Box executable are removed.

The justification for this is a result of the way 86BoxManagerX works: at first startup, it creates the configuration files after detecting the path to 86Box, and encodes the path to 86Box into the configuration file. After this, it does not try to find the 86Box executable again, even if it stops existing. It would be nice if the configuration could override the hardcoded path, but that'd be a much more involved patch, whereas this one is almost entirely just removing things, which should be easy to deal with. Adding upstream support for the hardcoded path might make this easier in the future.

P.S.: The reason the version string differs from the tag in having an additional hyphen is because buildDotnetModule disallows the string 1.7.6.0e.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jchv jchv force-pushed the init/86box-manager-x branch 3 times, most recently from 51e7863 to dfa57fd Compare November 1, 2024 15:47
@jchv
Copy link
Contributor Author

jchv commented Nov 1, 2024

Changelog from 4aae854 to faab013:

  • Changed pname to be lowercase, in accordance with the nixpkgs guidelines.
  • Applied suggestion to remove with lib usage.
  • Applied suggestion to use substituteAll instead of substitute for path patch.

Changelog from faab013 to 51e7863:

  • Formatted deps.nix, now that this is enforced by CI.

Changelog from 51e7863 to dfa57fd:

  • Reverted suggestion to use substituteAll. Upon further inspection, substituteAll silently ignores any variables that don't start with lowercase letters. I could change the patch, but it doesn't seem worth it. I'll change the patch if anyone thinks it would be worth it, but if so please leave a suggestion for what the variable should be called.

@jchv jchv force-pushed the init/86box-manager-x branch from dfa57fd to 2b0bb70 Compare November 2, 2024 18:00
Comment on lines +76 to +77
dotnet-sdk = dotnetCorePackages.sdk_6_0;
dotnet-runtime = dotnetCorePackages.runtime_6_0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 6 will be removed #326335

@jchv jchv marked this pull request as draft December 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants