Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libeduvpn-common: 1.2.1 -> 2.0.1 and eduvpn-client: 4.2.1 -> 4.3.0 #317385

Merged
merged 2 commits into from
Jun 15, 2024
Merged

libeduvpn-common: 1.2.1 -> 2.0.1 and eduvpn-client: 4.2.1 -> 4.3.0 #317385

merged 2 commits into from
Jun 15, 2024

Conversation

benneti
Copy link
Contributor

@benneti benneti commented Jun 5, 2024 •
edited
Loading

Description of changes

Packaging of upstream changed and needed some manual tweaks, replaces #317353

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@benneti
Copy link
Contributor Author

benneti commented Jun 5, 2024

I am not sure why the client now needs the postInstall thing, but the folders are not copied to the right place else, maybe you @jwijenbergh have a better idea what is happening there.

@benneti benneti mentioned this pull request Jun 5, 2024
Closed
@benneti benneti changed the title eduvpn 2.0 libeduvpn-common: 1.2.1 -> 2.0.0 and eduvpn-client: 4.2.1 -> 4.3.0 Jun 5, 2024
@benneti benneti requested a review from jwijenbergh June 5, 2024 08:32
@jwijenbergh
Copy link
Contributor

jwijenbergh commented Jun 5, 2024 •
edited
Loading

I am not sure why the client now needs the postInstall thing, but the folders are not copied to the right place else, maybe you @jwijenbergh have a better idea what is happening there.

Yeah I think my setup.cfg was not completely correct here, does it work without changes with this patch? eduvpn/python-eduvpn-client#595. If so I can tag 4.3.1 for you

@benneti
Copy link
Contributor Author

benneti commented Jun 5, 2024 •
edited
Loading

yes this works, and also get's rid of one of the nix specific patches 👍
EDIT: let me know if you tag a 4.3.1 and I'll update the PR accordingly and remove the manual patch

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 5, 2024
@ofborg ofborg bot requested a review from jwijenbergh June 5, 2024 09:16
@jwijenbergh
Copy link
Contributor

yes this works, and also get's rid of one of the nix specific patches 👍 EDIT: let me know if you tag a 4.3.1 and I'll update the PR accordingly and remove the manual patch

4.3.1 has been tagged, thank you for testing this!

jwijenbergh
jwijenbergh approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jwijenbergh jwijenbergh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks again

@benneti benneti added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 5, 2024
@jwijenbergh
Copy link
Contributor

@benneti i tagged another common version for some translations and some tiny changes

https://github.com/eduvpn/eduvpn-common/releases/tag/2.0.1

@benneti
Copy link
Contributor Author

benneti commented Jun 15, 2024

sorry for the delay, bumped and squashed

@benneti benneti changed the title libeduvpn-common: 1.2.1 -> 2.0.0 and eduvpn-client: 4.2.1 -> 4.3.0 libeduvpn-common: 1.2.1 -> 2.0.1 and eduvpn-client: 4.2.1 -> 4.3.0 Jun 15, 2024
@ofborg ofborg bot requested a review from jwijenbergh June 15, 2024 14:58
@h7x4 h7x4 merged commit 4a838cb into NixOS:master Jun 15, 2024
24 of 26 checks passed
@jwijenbergh
Copy link
Contributor

Thanks! @h7x4 @benneti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwijenbergh jwijenbergh Awaiting requested review from jwijenbergh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benneti @jwijenbergh @h7x4