Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arduino-cli: 1.0.1 -> 1.0.2, add myself as maintainer #324097

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

SFrijters
Copy link
Member

Description of changes

https://github.com/arduino/arduino-cli/releases/tag/v1.0.2

I've made most recent commits to this package in nixpkgs and I'm actively using it, so I think it makes sense to add myself as co-maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from ryantm July 2, 2024 18:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 2, 2024
@SFrijters SFrijters requested review from nagy and NickCao July 5, 2024 18:39
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 5, 2024
See arduino/arduino-cli#2653
"Changed license of .protoc definition to Apache-2.0"
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 324097 run on x86_64-linux 1

2 packages built:
  • arduino-ci
  • arduino-cli

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 07e7db2 into NixOS:master Jul 6, 2024
26 checks passed
@SFrijters SFrijters deleted the arduino-cli-1.0.2 branch July 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants