Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.j2cli: disable on python 3.12 #326134

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jul 10, 2024

Description of changes

$ nix run nixpkgs#j2cli -- -h
Traceback (most recent call last):
  File "/nix/store/mgizgbmlrz996i9rvpniga9mqbnkc6xz-python3.12-j2cli-0.3.10/bin/.j2-wrapped", line 6, in <module>
    from j2cli import main
  File "/nix/store/mgizgbmlrz996i9rvpniga9mqbnkc6xz-python3.12-j2cli-0.3.10/lib/python3.12/site-packages/j2cli/__init__.py", line 10, in <module>
    from j2cli.cli import main
  File "/nix/store/mgizgbmlrz996i9rvpniga9mqbnkc6xz-python3.12-j2cli-0.3.10/lib/python3.12/site-packages/j2cli/cli.py", line 8, in <module>
    import imp, inspect
ModuleNotFoundError: No module named 'imp'

kolypto/j2cli#80

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4233

@sikmir sikmir merged commit 4312c48 into NixOS:master Jul 13, 2024
25 checks passed
@sikmir sikmir deleted the j2cli branch July 13, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants