python312Packages.openstep-parser: init at 2.0.1 #335100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ofborg
bot
added
8.has: package (new)
fabaff
reviewed
Aug 16, 2024
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
from
a69f2a1 to
43ded29
Compare
github-actions
bot
added
the
8.has: maintainer-list (update)
|
@fabaff thanks for the suggestion, updated the PR |
ofborg
bot
added
the
11.by: package-maintainer
natsukium
previously requested changes
Aug 17, 2024
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
from
43ded29 to
b4f1410
Compare
ilaumjd
changed the title
|
@natsukium thanks for the correction, my bad that i was just copying from other example and not really looking into specific details of this package, updated the PR |
|
Result of 2 packages failed to build:
|
natsukium
reviewed
Aug 17, 2024
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
3 times, most recently
from
1659f3a to
4c705e6
Compare
emilazy
reviewed
Aug 18, 2024
|
maked this as draft since the source package itself is broken, thanks for pointing out @emilazy |
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
from
4c705e6 to
5f427ae
Compare
|
applied patch to the source code itself and build is working now, opening the PR again |
emilazy
requested changes
Aug 19, 2024
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
2 times, most recently
from
12d580a to
b0dbb77
Compare
ilaumjd
changed the title
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
from
b0dbb77 to
75344d0
Compare
Pandapip1
suggested changes
Aug 21, 2024
ilaumjd
force-pushed
the
pythonPackages.openstep-parser
branch
from
75344d0 to
0cdca2f
Compare
Pandapip1
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4439 |
emilazy
dismissed
natsukium’s stale review
All review comments were addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added
openstep-parser: A Python parser for OpenStep and Xcode project files. https://github.com/kronenthaler/openstep-parserThis package is required by this #335001
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.