Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux/common-config: enable support for crashkernel dumps #347932

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Scrumplex
Copy link
Member

I think it would be really useful for users to have crashkernel capabilities from the start, as this would allow wide deployments of this feature.
This would also be an opportunity to improve our tooling around crashkernel and perhaps automatically dump /sys/vmcore to a protected path for further debugging in the future.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 11, 2024
@Scrumplex Scrumplex marked this pull request as draft October 12, 2024 11:28
@Scrumplex Scrumplex force-pushed the nixos/crashdump/default-config branch from 8b15d99 to ae9dafd Compare October 12, 2024 11:28
@Scrumplex Scrumplex changed the base branch from master to staging October 12, 2024 11:28
@Scrumplex Scrumplex marked this pull request as ready for review October 12, 2024 11:28
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 12, 2024
@Scrumplex Scrumplex force-pushed the nixos/crashdump/default-config branch 2 times, most recently from 0b081b1 to d740b49 Compare November 3, 2024 11:58
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel changes generally go into master, we can merge this with the next round of updates.

Code-wise LGTM.

cc @K900 @alyssais

@Scrumplex Scrumplex marked this pull request as draft November 24, 2024 12:21
@Scrumplex Scrumplex force-pushed the nixos/crashdump/default-config branch from d740b49 to d8b5f03 Compare November 24, 2024 12:21
@Scrumplex Scrumplex changed the base branch from staging to master November 24, 2024 12:21
@Scrumplex Scrumplex marked this pull request as ready for review November 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants