stardrop: init at 1.2.1 #350713
Open
stardrop: init at 1.2.1 #350713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiedotcafe
force-pushed
the
stardrop
branch
from
a2d55a6 to
fc5db74
Compare
sofiedotcafe
force-pushed
the
stardrop
branch
from
fc5db74 to
7802e70
Compare
FliegendeWurst
added
the
12. first-time contribution
FliegendeWurst
requested changes
Nov 5, 2024
| postFixup = '' | ||
| for size in 16 24 32 48 64 128 256; do | ||
| mkdir -p $out/share/icons/hicolor/"$size"x"$size"/apps | ||
| magick ${./stardrop.ico} -background none -resize "$size"x"$size" -flatten \ |
There was a problem hiding this comment.
I don't think the icon needs to be converted to all possible sizes.
There was a problem hiding this comment.
I suppose the best size would be the size of the original ico file.
sofiedotcafe
force-pushed
the
stardrop
branch
from
7802e70 to
b1ec6e8
Compare
github-actions
bot
added
8.has: maintainer-list (update)
sofiedotcafe
force-pushed
the
stardrop
branch
from
b1ec6e8 to
204855f
Compare
sofiedotcafe
force-pushed
the
stardrop
branch
from
204855f to
49ff9c8
Compare
ofborg
bot
added
8.has: package (new)
FliegendeWurst
requested changes
Dec 3, 2024
Comment on lines
+34
to
+35
| dotnet-sdk = dotnetCorePackages.sdk_7_0; | ||
| dotnet-runtime = dotnetCorePackages.runtime_7_0; |
There was a problem hiding this comment.
.NET SDK 7 will be removed: #326335
Please try version 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Stardrop is an open-source, cross-platform mod manager for the game Stardew Valley.
https://floogen.gitbook.io/stardrop/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.