Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tclPackages.jimlib: init at 0.16.0 #352558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tclPackages.jimlib: init at 0.16.0 #352558

wants to merge 2 commits into from
+55 −0

Conversation

theneosloth
Copy link
Contributor

https://gitlab.com/dbohdan/jimlib

Utility library for Jimtcl and Tcl.

Tested a few of the functions with Tcl 8.6, which is the current version for mkTclDerivation

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: tcl labels Oct 31, 2024
@nix-owners nix-owners bot requested a review from fgaz October 31, 2024 08:05
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 31, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 31, 2024
fgaz
fgaz requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this round it should be good. Please also rebase your branch so that it contains only two commits: one for maintainers, and one for the package

pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Outdated
owner = "dbohdan";
repo = "jimlib";
rev = "v${version}";
sha256 = "sha256-a7Su/JByGLgnYBCRbP9z9CunTIYTwAisWuQafZWYgYo=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a SRI hash, so

Suggested change
sha256 = "sha256-a7Su/JByGLgnYBCRbP9z9CunTIYTwAisWuQafZWYgYo=";
hash = "sha256-a7Su/JByGLgnYBCRbP9z9CunTIYTwAisWuQafZWYgYo=";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased with the accurate version name. Thank you for the help and the patience 😄

pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Outdated Show resolved Hide resolved
@theneosloth theneosloth changed the title tclPackages.jimlib: init at 0.15.0 tclPackages.jimlib: init at 0.16.0 Nov 1, 2024
@theneosloth theneosloth requested a review from fgaz November 7, 2024 20:56
pluiedev
pluiedev reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Outdated Show resolved Hide resolved
pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Show resolved Hide resolved
pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Outdated Show resolved Hide resolved
pkgs/development/tcl-modules/by-name/ji/jimlib/package.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 28, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 28, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 29, 2024
@ofborg ofborg bot removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluiedev pluiedev pluiedev left review comments

@fgaz fgaz fgaz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: tcl 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theneosloth @fgaz @pluiedev