ente-auth: fix build failure because of wrong icon path

[MrSom3body]

Fix build failure for ente-auth.

ZHF: #352882

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[gepbird]

Thanks for your contribution!

@MrSom3body can you share more details about what are you trying to fix? This package builds for me on master, but I get this error with your change:

install: cannot stat '/nix/store/dxgqlaxsjydgxshh29f0qsz7jszlkdgs-ente-auth-4.0.2/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

To test the build yourself, you can run nix-build -A ente-auth from the root of your fork of nixpkgs.

[Aleksanaa]

Suggested change

	FAV=$out/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png
	ICO=$out/share/icons
	install -D $FAV $ICO/ente-auth.png
	install -D $out/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png -t $out/share/pixmaps

Delete the below lines about imagemagick. These should be useless

[gepbird]

ICO and FAV are also used in a for loop right below, I think its cleaner to keep those variables.

[Aleksanaa]

I'm saying the following should be removed. share/pixmaps is stipulated by the freedesktop specification, and this path does not need to specify the size. I don't think zooming with imagemagick is a good way.

Also remove imagemagick from nativeBuildInputs and function formal.

[gepbird]

Thanks for explaining this! Even though pixmaps is deprecated, it seems like better choice than creating images with imagemagick.

[niklaskorz]

Let's move this to a follow-up PR as it's irrelevant to this fix, so we can unbreak the build first.

[MrSom3body]

Thanks for your contribution!

@MrSom3body can you share more details about what are you trying to fix? This package builds for me on master, but I get this error with your change:

install: cannot stat '/nix/store/dxgqlaxsjydgxshh29f0qsz7jszlkdgs-ente-auth-4.0.2/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

To test the build yourself, you can run nix-build -A ente-auth from the root of your fork of nixpkgs.

Huh, that's weird, I get the same error message if I do not have the change. Here's my log.

Going into the directory that it build, I can see the following directory structure:

[niklaskorz]

Thanks for your contribution!
@MrSom3body can you share more details about what are you trying to fix? This package builds for me on master, but I get this error with your change:

install: cannot stat '/nix/store/dxgqlaxsjydgxshh29f0qsz7jszlkdgs-ente-auth-4.0.2/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

To test the build yourself, you can run nix-build -A ente-auth from the root of your fork of nixpkgs.

Huh, that's weird, I get the same error message if I do not have the change. Here's my log.

Going into the directory that it build, I can see the following directory structure:

Are you also using Lix, like the original reporter of the build failure?

[MrSom3body]

Yes, I am. So it seems to be a problem with lix and not with the package itself. Should I close the pull request then?

[zi3m5f]

install: cannot stat '/nix/store/q0ckhxy060rb82714z391xl0gfisqrsp-ente-auth-4.0.2/app/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

I get this error also with nix on both nixos-unstable-small and master. Tested with:

• nix-2.18.8
• nix-2.24.9
• lix-2.90.0
• lix-2.91.1

(I am also a lix user but tested and build in nix-shell -p nixVersions.nix_2_18 etc)

[niklaskorz]

install: cannot stat '/nix/store/q0ckhxy060rb82714z391xl0gfisqrsp-ente-auth-4.0.2/app/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

I get this error also with nix on both nixos-unstable-small and master. Tested with:

* nix-2.18.8

* nix-2.24.9

* lix-2.90.0

* lix-2.91.1

(I am also a lix user but tested and build in nix-shell -p nixVersions.nix_2_18 etc)

Spawning a shell is insufficient. The Nix daemon is unaffected by this.

[zi3m5f]

install: cannot stat '/nix/store/q0ckhxy060rb82714z391xl0gfisqrsp-ente-auth-4.0.2/app/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

I get this error also with nix on both nixos-unstable-small and master. Tested with:

* nix-2.18.8

* nix-2.24.9

* lix-2.90.0

* lix-2.91.1

(I am also a lix user but tested and build in nix-shell -p nixVersions.nix_2_18 etc)

Spawning a shell is insufficient. The Nix daemon is unaffected by this.

Sorry, didn't think.
I tested an fedora, my daemon is from nix-2.21.2 🤷‍♂️

[zi3m5f]

#345404 changed the installPhase of buildFlutterApplication.
Reverting fixes the error :)

[niklaskorz]

install: cannot stat '/nix/store/q0ckhxy060rb82714z391xl0gfisqrsp-ente-auth-4.0.2/app/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory

I get this error also with nix on both nixos-unstable-small and master. Tested with:

* nix-2.18.8

* nix-2.24.9

* lix-2.90.0

* lix-2.91.1

(I am also a lix user but tested and build in nix-shell -p nixVersions.nix_2_18 etc)

Spawning a shell is insufficient. The Nix daemon is unaffected by this.

Sorry, didn't think. I tested an fedora, my daemon is from nix-2.21.2 🤷‍♂️

Yeah can confirm for 2.18 now (back at my NixOS machine). And nice find. I just wonder why @chewblacka said the build worked for them without this fix.

[niklaskorz]

Building this PR fails for me:

       > install: cannot stat '/nix/store/dxgqlaxsjydgxshh29f0qsz7jszlkdgs-ente-auth-4.0.2/app/ente-auth/data/flutter_assets/assets/icons/auth-icon.png': No such file or directory
       For full logs, run 'nix log /nix/store/xsw15jfkniv34zbvlqc8s0d0hcg7ldml-ente-auth-4.0.2.drv'.

[niklaskorz]

Let's move this to a follow-up PR as it's irrelevant to this fix, so we can unbreak the build first.

[zi3m5f]

This fixes the error introduced by #345404 for me 👍

[niklaskorz]

Regarding my build failure, it looks like this PR branched off at the wrong point in history (before #345404 was merged), so building this PR's branch does not work. Rebasing it on top of current master works though.

[Aleksanaa]

This is not needed, because ofborg will rebase itself to master before testing, so does nixpkgs-review

[niklaskorz]

This is not needed, because ofborg will rebase itself to master before testing, so does nixpkgs-review

Yeah just wanted to clarify why it did not build for me at first :)
(I use nom build github:nixos/nixpkgs/<pr-commit>#ente-auth instead of nixpkgs-review)

[niklaskorz]

@MrSom3body can you add this text to the PR description, as this PR is part of ZHF:

ZHF: #352882

[MrSom3body]

Will do when I'm back home

[gepbird]

I tested it with nix-build and nom build in my local nixpkgs on NixOS, I'm also using Lix from nixpkgs that is a few days behind nixos-unstable. Works an master, fails on this PR.

Edit: After looking at the flutter PR that broke this package, I assume this fix is good but just to be sure I'm building it (also a webkitgtk rebuild is needed).

[gepbird]

Builds on x86_64-linux, thanks!