Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: request to join postgres team #353673

Closed
wants to merge 1 commit into from

Conversation

samrose
Copy link
Contributor

@samrose samrose commented Nov 4, 2024

I am upstreaming some work on postgres extensions and packages. I maintain package sets for the open source supabase release, and I'd like to be on the team to help nixpkgs postgres too

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/the-darwin-sdks-have-been-updated/55295/24

@wolfgangwalther
Copy link
Contributor

Related: #352905

TLDR: We are just kind of getting started with this.

I'm not 100% sure on the process here. Basic question for me is: Contribute first, then join the team or join the team first, then contribute? @Ma27 WDYT?

That being said: Very happy to have you help with postgresql. 🚀

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 5, 2024
@samrose
Copy link
Contributor Author

samrose commented Nov 5, 2024

Feel free to close this one if there is a different desired way to proceed with this request.

@Aleksanaa
Copy link
Member

I don't think you have to wait for someone's approval.

@samrose samrose closed this Nov 6, 2024
@samrose samrose deleted the join-postgres-team branch November 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants