-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
froide: init at 0-unstable-2024-11-22; nixos/froide: init #355835
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to clarify which country/region this app is for? Also please run nixfmt on your changes (except for large files like all-packages.nix, python-modules.nix, etc), and reorder commits so that froide's dependencies are added before froide itself
in { | ||
options.services.froide = { | ||
|
||
enable = lib.mkEnableOption "Gouvernment planer web app Govplan"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User-facing documentation should be (unfortunately) in English
froide = { | ||
description = "Gouvernment planer Govplan"; | ||
serviceConfig = { | ||
ExecStart = "${pkgs.froide}/bin/froide runserver 0.0.0.0:8000"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding host & port options
EnvironmentFile = [ | ||
( format.generate "froide-env" cfg.settings ) | ||
cfg.secrets | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: hardening?
@@ -0,0 +1,90 @@ | |||
import ./make-test-python.nix ({ lib, ... }: { | |||
name = "paperless"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still paperless
postInstall = '' | ||
cp manage.py $out/ | ||
makeWrapper $out/manage.py $out/bin/froide \ | ||
--prefix PYTHONPATH : "$PYTHONPATH" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should already happen when patching interpreters in fixupPhase
description = "Freedom of Information Portal"; | ||
homepage = "https://github.com/okfde/froide"; | ||
license = lib.licenses.mit; | ||
maintainers = [ lib.maintainers.onny ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing mainProgram
, and platforms
if applicable
dependencies = [ django ]; | ||
|
||
checkPhase = '' | ||
${python.interpreter} manage.py test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't python3
already be in PATH? Plus, python means Python 2 (!)
770a98b
to
c63c317
Compare
955daac
to
f18d580
Compare
Adding web app froide, a portal for creating and following freedom of information act requests. Used by FragDenStaat project
Depends on:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.