nixos/mopidy: test & cleanup #356021
nixos/mopidy: test & cleanup #356021
Conversation
github-actions
bot
added
6.topic: nixos
Stunkymonkey
changed the title
Stunkymonkey
force-pushed
the
nixos-mopidy-package
branch
from
619a262
to
e931969
Compare
ofborg
bot
added
10.rebuild-darwin: 0
| mopidyEnv = pkgs.buildEnv { | ||
| name = "mopidy-with-extensions-${cfg.package.version}"; | ||
| paths = lib.closePropagation cfg.extensionPackages; | ||
| pathsToLink = [ "/${pkgs.mopidyPackages.python.sitePackages}" ]; |
There was a problem hiding this comment.
I'm concerned that this might allow mixing the extension packages and the mopidy package in an unsafe way.
For instance, assume that this service is being used from a stable branch of NixOS.
If someone sets the package option to use the unstable Mopidy package, what happens when the branches target different versions of Python?
Which version of Python will be used, the one from stable or unstable? Or perhaps it will use some combination of versions?
There was a problem hiding this comment.
should we provide an additional option for the mopidyPackages?
There was a problem hiding this comment.
I was leaning toward something like that. It just makes me wonder if there still needs to be an option for mopidy then.
There was a problem hiding this comment.
what i want to prevent is something like this (which could solve it): https://github.com/NixOS/nixpkgs/blob/nixos-24.05/nixos/modules/virtualisation/qemu-vm.nix#L668
can we assert that somehow?
i will ask around in the matrix-room for some suggestions.
Stunkymonkey
force-pushed
the
nixos-mopidy-package
branch
from
29c87a2
to
0c0bcb5
Compare
|
@jwillikers maybe we first merge everything except the package option? |
That sounds great to me! |
Stunkymonkey
force-pushed
the
nixos-mopidy-package
branch
from
0c0bcb5
to
9262fc4
Compare
Stunkymonkey
changed the title
adding test and cleanup
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.