-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vikunja: 0.24.4 -> 0.24.5 #357992
vikunja: 0.24.4 -> 0.24.5 #357992
Conversation
OK interesting it was necessary on master from ~2ish weeks ago. |
The change that required the nix-ld patch is not in this release. This only contains the few commits backported with the security fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but haven't built locally (not on a pc right now). Will do that tomorrow but I don't want to block merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully created backport PR for |
https://vikunja.io/changelog/vikunja-v0.24.5-was-released
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.