Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vikunja: 0.24.4 -> 0.24.5 #357992

Merged
merged 1 commit into from
Nov 21, 2024
Merged

vikunja: 0.24.4 -> 0.24.5 #357992

merged 1 commit into from
Nov 21, 2024

Conversation

leona-ya
Copy link
Member

https://vikunja.io/changelog/vikunja-v0.24.5-was-released

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 21, 2024
@leona-ya leona-ya requested review from Ma27 and kolaente November 21, 2024 20:48
@leona-ya
Copy link
Member Author

@Ma27 said this probably needs a nix-ld patch because of a dynamically linked bin. But for me it works just fine (without nix-ld enabled), so it's probably not necessary?

@leona-ya leona-ya added the backport release-24.11 Backport PR automatically label Nov 21, 2024
@Ma27
Copy link
Member

Ma27 commented Nov 21, 2024

OK interesting it was necessary on master from ~2ish weeks ago.

@kolaente
Copy link
Member

The change that required the nix-ld patch is not in this release. This only contains the few commits backported with the security fix.

Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but haven't built locally (not on a pc right now). Will do that tomorrow but I don't want to block merging this.

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Result of nixpkgs-review pr 357992 run on aarch64-linux 1

1 package built:
  • vikunja

@tomodachi94 tomodachi94 merged commit 351d61c into NixOS:master Nov 21, 2024
18 of 19 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.11:

@leona-ya leona-ya deleted the vikunja-0.24.5 branch November 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants