feat(compilers): add mainProgram attribute to lisp compilers #358036
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
tani
added a commit
to tani/nix-common-lisp
that referenced
this pull request
Nov 22, 2024
Added a workaround for the issue described in NixOS/nixpkgs#358036. Updated the flake.nix file to include necessary patches and changes to handle different Lisp implementations more effectively.
tani
added a commit
to tani/nix-common-lisp
that referenced
this pull request
Nov 22, 2024
simplify NixOS/nixpkgs#358036 and updated the overlay configuration in flake.nix. This change reduces complexity and improves maintainability.
|
changes look good. commit message should be changed before merging. our conventions are here, though the edge case here of changes small enough to not warrant distinct commits but which affect multiple packages is under-documented. in this case, we write it "treewide: (description of changes)", like "treewide: add |
uninsane
reviewed
Nov 23, 2024
tani
force-pushed
the
lisp-mainProgram
branch
from
0d29b99
to
36453c8
Compare
|
Thank you, @uninsane! I've updated the commit message as suggested and sorted the attributes alphabetically for better readability and consistency. Please have a look and let me know if there’s anything else to address! |
uninsane
force-pushed
the
lisp-mainProgram
branch
from
36453c8
to
65f013d
Compare
uninsane
approved these changes
Nov 24, 2024
uninsane
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mainProgram attribute to the meta section of the following compilers:
This change helps in identifying the main executable for each compiler.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.