-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql: add new feature options #358238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me a different derivation than on the merge-base with master. I'm pretty sure this is because the order of buildInputs
is different, hence this is a mass-rebuild and will need to target staging[1].
Sure, we could also retain the order, but I think this would make the expression weirder than it needs to be, so I think just waiting is OK.
[1] Kinda sucks that ofborg got even slower so I have to de facto do those checks on my again 🙄
A bit of structure and much more diff-friendly.
f8bddac
to
4aa1cda
Compare
Ah, good catch. I wasn't 100% sure and wanted to let ofborg tell me about that. But you are quicker than ofborg is. ;)
Yeah, it's so annoying currently.. most of my PRs are waiting for OfBorg multiple days. The feedback cycle is soo slow. |
I've been told that it's probably not possible anymore for the workers to keep up with the stream of incoming PRs (+ that it's probably not getting cheaper to perform those evaluations). There are people trying to use GHA more (and also movements to keep ofborg running with more hardware sponsored from several parties), let's hope that one of those things works out. |
We already do have GHA‐based evaluation; that’s what the “Outpaths” jobs on this PR are. |
Yep, seen those. |
You can download the outpaths from the action result to get the data, but yes, no fancy labelling as of yet AFAIK. |
I think it has the outpaths only, but not the diff (and thus rebuild count) from what I see in the zipball. Anyways, from what I see, I'm positively surprised then, nice. |
This makes almost everything that PostgreSQL supports to be built with available as
xSupport
flags. Bonjour only works on darwin, selinux only on Linux - all others seem to work fine on both, except for a failed output check on darwin with ldap enabled. I don't consider that critical for now, though.The idea here is to provide those options - and then have separate discussions and much more tests if we decide to turn any of them on by default.
Supersedes #218934 and makes #345289 a tiny bit nicer to implement.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.