python312Packages.python-bitcoinlib: rename from bitcoinlib

[cooparo]

It think is confusing calling this package bitcoinlib because this is the name of a different package on the Python Package Index, so maybe it's better to use the same name.

See:

• bitcoinlib
• python-bitcoinlib

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[dotlambda]

Please also change the attribute name in pkgs/top-level/python-packages.nix and replace all occurrences treewide.

[cooparo]

Please also change the attribute name in pkgs/top-level/python-packages.nix and replace all occurrences treewide.

Now should be okay

[dotlambda]

Could you make the commit message say something like "rename to python-bitcoinlib"?

[cooparo]

Could you make the commit message say something like "rename to python-bitcoinlib"?

I dont't understand, the commit message is "refactor pname to python-bitcoinlib" already, what else should I write?

[dotlambda]

Could you make the commit message say something like "rename to python-bitcoinlib"?

I dont't understand, the commit message is "refactor pname to python-bitcoinlib" already, what else should I write?

My suggestion is in the PR title. The problem is that we're not only changing the pname.

[cooparo]

I think I have just merged my inability to use git and my inability to spell correctly bitcoinlib. In the end, I hope did right.

[dotlambda]

Please squash your commits.

[cooparo]

Ok, should be good (hope it's the last time I say it)

[dotlambda]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358492

---

x86_64-linux

✅ 12 packages built:

• opentimestamps-client
• opentimestamps-client.dist
• prometheus-bitcoin-exporter
• python311Packages.opentimestamps
• python311Packages.opentimestamps.dist
• python311Packages.python-bitcoinlib
• python311Packages.python-bitcoinlib.dist
• python312Packages.opentimestamps
• python312Packages.opentimestamps.dist
• python312Packages.python-bitcoinlib
• python312Packages.python-bitcoinlib.dist
• zeronet-conservancy