Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups-filters: 1.28.17 -> 2.0.1 #358724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 24, 2024

Seems to work (test page prints successfully from system-config-printers), done:

  • add libcupsfilters package
  • add libppd package
  • tested I can print a test page via system-config-printers
  • check libcupsfilters for missing optional dependencies
  • check libppd for missing optional dependencies
  • check cups/filter.nix for now-unneeded dependencies
  • also package cups-browsed separately
  • formatting
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@raboof raboof force-pushed the cups-filters-1.28.17-to-2.0.1 branch from 24bd5cc to 0b9b205 Compare November 24, 2024 14:51
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 24, 2024
@raboof raboof force-pushed the cups-filters-1.28.17-to-2.0.1 branch from 0b9b205 to 13cfa1e Compare November 24, 2024 14:53
@raboof raboof force-pushed the cups-filters-1.28.17-to-2.0.1 branch 2 times, most recently from f7a5cc5 to 9a5b2e9 Compare November 25, 2024 13:17
@raboof raboof marked this pull request as ready for review November 25, 2024 13:19
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for untangling this!

We might need to remove NetCUPS from the deps of ocsinventory-agent and mark NetCUPS as broken. Alternatively, and maybe a better solution, Ubuntu seems to carry a compatibility patch for NetCUPS we might be able to apply, see https://git.launchpad.net/ubuntu/+source/libnet-cups-perl/tree/debian/patches/cupsfilters-2.0.patch?id=a47b8df8551853c12a7f965ae60bb52333883c88

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358724


aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 6 packages failed to build:
  • ocsinventory-agent
  • ocsinventory-agent.devdoc
  • perl538Packages.NetCUPS
  • perl538Packages.NetCUPS.devdoc
  • perl540Packages.NetCUPS
  • perl540Packages.NetCUPS.devdoc
✅ 10 packages built:
  • cups-browsed
  • cups-filters
  • foomatic-db
  • foomatic-db-ppds
  • foomatic-db-ppds-withNonfreeDb
  • libcupsfilters
  • libppd
  • ptouch-driver
  • splix
  • system-config-printer

pkgs/misc/cups/filters.nix Outdated Show resolved Hide resolved
@raboof raboof force-pushed the cups-filters-1.28.17-to-2.0.1 branch 2 times, most recently from 401db4b to 3b0408c Compare November 26, 2024 21:22
@raboof raboof force-pushed the cups-filters-1.28.17-to-2.0.1 branch from 3b0408c to f1f9a54 Compare November 27, 2024 08:46
@raboof
Copy link
Member Author

raboof commented Nov 28, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358724


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 16 packages built:
  • cups-browsed
  • cups-filters
  • foomatic-db
  • foomatic-db-ppds
  • foomatic-db-ppds-withNonfreeDb
  • libcupsfilters
  • libppd
  • ocsinventory-agent
  • ocsinventory-agent.devdoc
  • perl538Packages.NetCUPS
  • perl538Packages.NetCUPS.devdoc
  • perl540Packages.NetCUPS
  • perl540Packages.NetCUPS.devdoc
  • ptouch-driver
  • splix
  • system-config-printer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants